Skip to content

Add CHROME_FLAGS, FIREFOX_FLAGS, and NODE_FLAGS#89

Merged
ryanking13 merged 1 commit intopyodide:mainfrom
hoodmane:flags
May 9, 2023
Merged

Add CHROME_FLAGS, FIREFOX_FLAGS, and NODE_FLAGS#89
ryanking13 merged 1 commit intopyodide:mainfrom
hoodmane:flags

Conversation

@hoodmane
Copy link
Copy Markdown
Member

@hoodmane hoodmane commented May 9, 2023 •
edited
Loading

So that we can add extra flags to the runtimes if we need to.

Used in pyodide/pyodide#3210

@hoodmane hoodmane mentioned this pull request May 9, 2023
Merged
4 tasks
ryanking13
ryanking13 approved these changes May 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hoodmane! Maybe we can change this into a pytest option later, but for now this is fine with me.

@ryanking13 ryanking13 merged commit 54de3f9 into pyodide:main May 9, 2023
@hoodmane hoodmane deleted the flags branch May 9, 2023 05:02
@hoodmane
Copy link
Copy Markdown
Member Author

hoodmane commented May 9, 2023

Thanks for the review @ryanking13. Can we release a new version of pytest-pyodide with this? (I'm not sure what the release process is for pytest-pyodide...)

@ryanking13
Copy link
Copy Markdown
Member

ryanking13 commented May 9, 2023

Can we release a new version of pytest-pyodide with this?

Sure, but if you are not very busy, would you please review #87, so we can include it in the next release? (If you have some comments on it, then feel free to release without it because it's very easy to release pytest-pyodide :) )

(I'm not sure what the release process is for pytest-pyodide...)

Update the changelog and push a new tag.

@ryanking13
Copy link
Copy Markdown
Member

ryanking13 commented May 9, 2023

BTW, I think there was some problem in Github notification system yesterday and today. I didn't get notifications about new issues and PRs.

@ryanking13
Copy link
Copy Markdown
Member

ryanking13 commented May 10, 2023

@hoodmane I made a v0.51.0 release so you'll soon be able to use it.

@hoodmane
Copy link
Copy Markdown
Member Author

hoodmane commented May 10, 2023

Thanks @ryanking13!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanking13 ryanking13 ryanking13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoodmane @ryanking13