Skip to content

Run host tests by default#33

Merged
rth merged 8 commits intopyodide:mainfrom
ryanking13:runtime-list
Sep 8, 2022
Merged

Run host tests by default#33
rth merged 8 commits intopyodide:mainfrom
ryanking13:runtime-list

Conversation

@ryanking13
Copy link
Copy Markdown
Member

@ryanking13 ryanking13 commented Sep 8, 2022

Close #32

The changes that I made in this PR are:

  1. Run host tests by default, unless -no-host is given (e.g. chrome-no-host, firefox-no-host).
  2. Remove the option all and support passing list of runtimes. (e.g. --rt chrome --rt firefox)
    • I found that the option all was acutally not working correctly.
  • changelog

Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ryanking13 !

@rth rth merged commit bf5b814 into pyodide:main Sep 8, 2022
@@ -1,3 +1,8 @@
## [0.22.2] - 2002.09.08
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we are not in 2002 ^^ I'll push a fix.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Host tests are skipped by default

2 participants