Move ensure_rust_toolchain to buildall#83
Merged
hoodmane merged 6 commits intopyodide:mainfrom Jan 15, 2025
Merged
Conversation
Rather than installing the rust toolchain in each build step that uses rust, do it once in buildall [integration]
hoodmane
commented
Jan 15, 2025
| RUST_BUILD_PRELUDE = """ | ||
| rustup toolchain install ${RUST_TOOLCHAIN} && rustup default ${RUST_TOOLCHAIN} | ||
| rustup target add wasm32-unknown-emscripten --toolchain ${RUST_TOOLCHAIN} | ||
| rustup default ${RUST_TOOLCHAIN} |
Member
Author
There was a problem hiding this comment.
I suppose we could also do this in _ensure_rust_toolchain() and remove RUST_BUILD_PRELUDE entirely.
Member
There was a problem hiding this comment.
Then , will pyodide build-recipes-no-deps work?
ryanking13
approved these changes
Jan 15, 2025
Member
ryanking13
left a comment
There was a problem hiding this comment.
Thanks. Mostly looks good to me. But please check it works correctly with pyodide build-recipes-no-deps CLI.
Also you can add [integration] in the commit message to run integration test, which includes building cryptography package.
| RUST_BUILD_PRELUDE = """ | ||
| rustup toolchain install ${RUST_TOOLCHAIN} && rustup default ${RUST_TOOLCHAIN} | ||
| rustup target add wasm32-unknown-emscripten --toolchain ${RUST_TOOLCHAIN} | ||
| rustup default ${RUST_TOOLCHAIN} |
Member
There was a problem hiding this comment.
Then , will pyodide build-recipes-no-deps work?
Member
Author
|
Thanks for the review @ryanking13! Will check for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than installing the rust toolchain in each build step that uses rust, do it once in buildall.
Work split off from #81.