Use _Py_Version to compute Python version for library setup #5406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires this upstream fix which came out in Emscripten 3.1.73: emscripten-core/emscripten#23020 Applied upstream in the cpython repo here: https://github.com/python/cpython/pull/127113/files#diff-31f61a127a59386957acba86e9acedf0a96bc6ebe1ac159a48e39b1a291111b5R73-R75 This fixes an error that occurs when building with assertions -- we called `_py_version_major` before the runtime was set up so it triggered an assertion failure.
agriyakhetarpal
approved these changes
Feb 3, 2025
Member
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Looks good to me, thanks, @hoodmane!
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires this upstream fix which came out in Emscripten 3.1.73: emscripten-core/emscripten#23020
Applied upstream in the cpython repo here:
https://github.com/python/cpython/pull/127113/files#diff-31f61a127a59386957acba86e9acedf0a96bc6ebe1ac159a48e39b1a291111b5R73-R75
This fixes an error that occurs when building with assertions -- we called
_py_version_majorbefore the runtime was set up so it triggered an assertion failure.