Skip to content

SciPy v1.13.1#5011

Merged
agriyakhetarpal merged 4 commits intopyodide:mainfrom
agriyakhetarpal:feat/package/scipy-1.13.1
Aug 15, 2024
Merged

SciPy v1.13.1#5011
agriyakhetarpal merged 4 commits intopyodide:mainfrom
agriyakhetarpal:feat/package/scipy-1.13.1

Conversation

@agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Aug 15, 2024 •
edited
Loading

Description

This PR updates SciPy to version 1.13.1. Tagging recipe maintainers: @lesteve, @steppi; and @rgommers, for visibility. SciPy was previously updated in #4719 to version 1.13.0.

Checklists

@agriyakhetarpal agriyakhetarpal mentioned this pull request Aug 15, 2024
Merged
2 tasks
@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Aug 15, 2024

SciPy builds successfully and all tests are passing for its test suite. I'll look at the test-packages-chrome and test-packages-node jobs when they finish since they are running some additional tests (I think), and if there is nothing concerning, I shall merge this PR.

@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Aug 15, 2024

Tests are passing for Chrome and Node – I shall update the CHANGELOG and merge

@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Aug 15, 2024

Passing for Firefox as well. PyArrow's test failed for Firefox (passed elsewhere), albeit due to a timeout – if it fails more often, we can increase the timeout.

@agriyakhetarpal agriyakhetarpal merged commit 09bdc8d into pyodide:main Aug 15, 2024
@agriyakhetarpal agriyakhetarpal deleted the feat/package/scipy-1.13.1 branch August 15, 2024 22:19
This was referenced Aug 16, 2024
Merged
Open
@hoodmane
Copy link
Member

hoodmane commented Aug 20, 2024

@agriyakhetarpal I'm getting a scipy build failure in CI:

'scipy/stats/_stats_pythran.cpython-312-wasm32-emscripten.so.p/_stats_pythran.cp
p'                                                                              
FAILED:                                                                         
scipy/stats/_stats_pythran.cpython-312-wasm32-emscripten.so.p/_stats_pythran.cpp
/tmp/build-env-nnsn2be9/bin/pythran -E ../scipy/stats/_stats_pythran.py -o      
scipy/stats/_stats_pythran.cpython-312-wasm32-emscripten.so.p/_stats_pythran.cpp
Traceback (most recent call last):                                              
  File "/tmp/build-env-nnsn2be9/bin/pythran", line 8, in <module>               
    sys.exit(run())                                                             
             ^^^^^                                                              
  File "/tmp/build-env-nnsn2be9/lib/python3.12/site-packages/pythran/run.py",   
line 181, in run                                                                
    pythran.compile_pythranfile(args.input_file,                                
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                 
  File                                                                          
"/tmp/build-env-nnsn2be9/lib/python3.12/site-packages/pythran/__init__.py", line
127, in __getattr__                                                             
    import pythran.toolchain                                                    
  File                                                                          
"/tmp/build-env-nnsn2be9/lib/python3.12/site-packages/pythran/toolchain.py",    
line 11, in <module>                                                            
    from pythran.dist import PythranExtension, PythranBuildExt                  
  File "/tmp/build-env-nnsn2be9/lib/python3.12/site-packages/pythran/dist.py",  
line 139, in <module>                                                           
    class PythranBuildExt(PythranBuildExtMixIn, LegacyBuildExt,                 
metaclass=PythranBuildExtMeta):                                                 
TypeError: metaclass conflict: the metaclass of a derived class must be a       
(non-strict) subclass of the metaclasses of all its bases

@hoodmane
Copy link
Member

hoodmane commented Aug 20, 2024

I wonder if pythran released an update in the last five days?

@hoodmane
Copy link
Member

hoodmane commented Aug 20, 2024

Nope looks like last update to Pythran was 2024-05-14.

@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Aug 20, 2024

That does look new. I'm sure SciPy was built without issues and passed successfully before I merged. The latest Pythran on PyPI is https://pypi.org/project/pythran/0.16.1/

@rgommers
Copy link
Contributor

rgommers commented Aug 20, 2024 via email

@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Aug 20, 2024

Yes, that should be it indeed; also note that Pythran 0.15.0 and 0.16.0 have wheels on PyPI, but 0.16.1 does not – it has just the sdist.

@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Aug 20, 2024

xref to scipy/scipy#21416 where this was reported and in Pythran at serge-sans-paille/pythran#2228, which will be closed by serge-sans-paille/pythran#2229.

@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Aug 20, 2024

Ah, @ryanking13 opened #5018 for this, just noticed 😄

@agriyakhetarpal agriyakhetarpal mentioned this pull request Aug 20, 2024
Closed
@agriyakhetarpal agriyakhetarpal mentioned this pull request Sep 2, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agriyakhetarpal @hoodmane @rgommers