Merged
Conversation
…into unvendor-build
This was referenced Jun 29, 2024
Member
Author
|
This is ready to be reviewed now. |
hoodmane
reviewed
Jul 17, 2024
hoodmane
reviewed
Jul 17, 2024
hoodmane
reviewed
Jul 17, 2024
hoodmane
reviewed
Jul 17, 2024
hoodmane
reviewed
Jul 17, 2024
Makefile.envs
Outdated
| export PYODIDE_EMSCRIPTEN_VERSION ?= 3.1.58 | ||
| export PYODIDE_VERSION ?= 0.27.0.dev0 | ||
| export PYODIDE_ABI_VERSION ?= 2024_0 | ||
| export PYODIDE_BUILD_VERSION ?= 0.27.3 |
Member
There was a problem hiding this comment.
I wonder if we should add optional PYODIDE_BUILD_REPO and PYODIDE_BUILD_COMMIT -- if these are defined, we can check in the pyodide_build rule that direct_url.json exists and has appropriate contents. Then perhaps we should install pyodide_build everywhere with make pyodide_build...?
Member
Author
There was a problem hiding this comment.
Sounds reasonable to me. Let me see if I can make it work.
1 task
for more information, see https://pre-commit.ci
…into unvendor-build
for more information, see https://pre-commit.ci
…into unvendor-build
hoodmane
reviewed
Jul 22, 2024
hoodmane
reviewed
Jul 22, 2024
hoodmane
reviewed
Jul 23, 2024
| --verbose \ | ||
| --runtime=host \ | ||
| --cov=pyodide_build --cov=pyodide \ | ||
| src pyodide-build packages/micropip/ packages/_tests tools/ |
Member
There was a problem hiding this comment.
Is there a reason you deleted packages/micropip and packages/_tests here?
Member
Author
There was a problem hiding this comment.
I put back packages/_tests. packages/micropip is not needed as there is no host test in micropip anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pyodide-build now lives in pyodide/pyodide-build.
After this change,