Remove pycryptodomex from the package list#3261
Merged
hoodmane merged 1 commit intopyodide:mainfrom Nov 16, 2022
Merged
Conversation
hoodmane
approved these changes
Nov 16, 2022
Member
hoodmane
left a comment
There was a problem hiding this comment.
Thanks @ryanking13 this has confused me several times.
Member
Why did we have the output wheel in the dist folder then in the commit before this one (cf build-packages CI), (I also had trouble with it because it's an abi3 wheel, and assumed that cp35 was OK in this case, but maybe I'm wrong). |
Member
|
OK, different name, makes sense ) |
Member
|
Yeah the fact that it's one letter different really confused me more than once too. This is kind of funny. The abi3 rule is the cp35 has to be <= current interpreter (idea being that things are added to stable ABI but not removed or changed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pycryptodomex was added in #2966, but it had an invalid recipe name
meta.yml(notmeta.yaml) so our build system didn't build that package.I found that in #3006, and I also found that it is not building well, so I disabled it then. So, in other words, pycryptodomex never worked in Pyodide.
I would like to remove it from the changelog and the repository for now, so that we don't add it to our next stable release accidentally. Perhaps someone interested can re-add this package.
cc: @Starz0r
Checklists