Skip to content

Update scipy to 1.9.1 (no meson)#3043

Merged
hoodmane merged 6 commits intopyodide:mainfrom
hoodmane:scipy-1.9-no-meson
Sep 5, 2022
Merged

Update scipy to 1.9.1 (no meson)#3043
hoodmane merged 6 commits intopyodide:mainfrom
hoodmane:scipy-1.9-no-meson

Conversation

@hoodmane
Copy link
Copy Markdown
Member

@hoodmane hoodmane commented Aug 30, 2022

This updates scipy to v1.9.1. This was mercifully easy:

  • for now we disable meson
  • we dropped patches/0014-BUG-Fix-signature-of-D_IIR_forback-1-2.patch since it was upstreamed
  • we had to add a patch to put fitpack back into a shape that makes f2c happy
  • we need one more -Wincompatible-function-pointer-types fix upstream PR: MAINT: cast linear_sum_assignment to PyCFunction scipy/scipy#16934

Checklists

@hoodmane hoodmane mentioned this pull request Aug 30, 2022
@rgommers
Copy link
Copy Markdown
Contributor

That all looks good. I'll have a look at your new upstreamed patch now.

Copy link
Copy Markdown
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hoodmane! We might not need cython pinning now.

"cython<0.29.31", # cython 0.29.31 is incompatible with scipy 1.8.1. TODO: remove this after the scipy update.

@hoodmane hoodmane merged commit 525b5a1 into pyodide:main Sep 5, 2022
@hoodmane hoodmane deleted the scipy-1.9-no-meson branch September 5, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants