ENH Add a check for the browser shim of process when determining if the runtime is Node#2010
Merged
rth merged 3 commits intopyodide:mainfrom Dec 2, 2021
Merged
ENH Add a check for the browser shim of process when determining if the runtime is Node#2010rth merged 3 commits intopyodide:mainfrom
rth merged 3 commits intopyodide:mainfrom
Conversation
Member
|
Thanks! Please remove the checklist entries in your issue description if you don't plan to add them. I think this is probably fine without a test. Generally LGTM. |
Contributor
Author
Cool! Thanks for the reply; I removed the checklist. |
Contributor
Author
|
Could this be merged perhaps, despite the timed out and therefore failed build? It would help the starboard-notebook project quite a bit if it doesn't have to patch the pyodide package after installation. I'm hoping this fix gets in the next pyodide release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's a browser shim for process, in which case we don't want to set
IN_NODEtotrue.From: https://www.npmjs.com/package/process
This fixes that packages like
starboard-notebookhave to patchpyodideat install time.