Merged
Conversation
rth
approved these changes
Nov 12, 2021
Member
rth
left a comment
There was a problem hiding this comment.
The CI looks OK now. I think we can include it, but we would first need to add a bit more documentation of these patches.
Member
Author
|
I think if we just put |
Member
|
I added a few more comments to patches, otherwise good to merge. @joemarshall did a great job and fixed most of these upstream, so there isn't much left to do for us here. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fpcast branch #1677 crashes chrome in CI but not when testing locally. These patches work fine by themselves. Maybe reducing the diff might help with debugging that.