Add basic tests for macOS app bundle codesigning#7187
Merged
rokm merged 2 commits intopyinstaller:developfrom Oct 25, 2022
Merged
Add basic tests for macOS app bundle codesigning#7187rokm merged 2 commits intopyinstaller:developfrom
rokm merged 2 commits intopyinstaller:developfrom
Conversation
If PYINSTALLER_STRICT_BUNDLE_CODESIGN_ERROR is set and its value is different from 0, the error coming from codesign when trying to sign the bundle will raise an error instead of just displaying the warning. Intended for use in our CI.
The tests enable strict bundle signing error handling, and verify three scenarios (using psutil as the test package): - we collect metadata for the test package, to ensure it is properly relocated - we collect the test package as .py files, which are not relocated - we collect the test package as .pyc files, which are not relocated
bwoodsend
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement basic tests for macOS app bundle signing, to hopefully prevent regressions in basic relocation functionality, like the one caused by typo in #7180 (see #7184, #7185).
Add an option to turn the codesign error when signing the generated app bundle into fatal error, so we can catch it on the CI.
Add basic tests that:
Also sneak in a news fragment for #7184, so that the changelog for hotfix release will make note of it.