Skip to content

Drop Python 3.3 support#3045

Closed
ghost wants to merge 4 commits intodevelopfrom
unknown repository
Closed

Drop Python 3.3 support#3045
ghost wants to merge 4 commits intodevelopfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Nov 28, 2017

Python 3.3 has reach EOL.

@ghost
Copy link
Author

ghost commented Nov 28, 2017

@htgoebel Can you go ahead and squash-merge this?

@ghost
Copy link
Author

ghost commented Nov 29, 2017

@htgoebel I would recommend merging this ASAP to resolve test failures.

@htgoebel
Copy link
Member

Python 3.3 has reach EOL.

What is the urgent need to drop this? (I did not have time yet to check the test failures.)

@htgoebel
Copy link
Member

Also when dropping all code specific to Py 3.3 should be removed.

@ghost
Copy link
Author

ghost commented Nov 29, 2017

Dependencies are dropping 3.3. Dropping all code is going to need a longer PR, and it's important to fix the failing tests.

@htgoebel
Copy link
Member

But why they are now failing? They did not fail yesterday. Why can't they be fixed?

(Yes, I know, 3.3. is EOL. But we need a PyInstaller bug-fix release and can't drop Py3.3. support for this. Thus even removing Py 3.3 from the tests can not be done quickly.)

@ghost
Copy link
Author

ghost commented Nov 29, 2017

See pytest-dev/py#175.

@htgoebel
Copy link
Member

So the simpler solution would be to pin pytest – as long as we no not require a new version.

@ghost
Copy link
Author

ghost commented Nov 29, 2017

Yes but that kills #3049. If it was worth killing, then I would say it's fine, but I don't see the point of working on an EOL Python. Even security issues are not fixed.

@ghost ghost closed this Dec 1, 2017
@ghost ghost deleted the drop_33 branch December 1, 2017 06:52
@hugovk
Copy link
Contributor

hugovk commented Dec 1, 2017

I'd just drop 3.3, hardly anyone uses it.

Here's the pip installs for pyinstaller from PyPI for the last month (via pypinfo --percent --pip pyinstaller pyversion), showing a very small fraction for 3.3:

python_version percent download_count
2.7 48.4% 26,288
3.6 24.9% 13,563
3.5 18.1% 9,857
3.4 7.1% 3,833
2.6 0.9% 496
3.7 0.5% 268
3.3 0.1% 50
3.2 0.0% 5
None 0.0% 2

@htgoebel
Copy link
Member

htgoebel commented Dec 1, 2017

When dropping Py 3.3, this should be done completely, this pull-request did only remove it from the tests.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants