Add pyi as short name for python#2773
Merged
birkenfeld merged 2 commits intopygments:masterfrom Aug 28, 2024
Merged
Conversation
Member
|
Thanks for the PR, if you want this to be merged please keep the style consistent (space after comma, single quotes). |
7947991 to
453c95b
Compare
Contributor
Author
Apologies. Updated now. Should a change log note also be added? |
Member
|
Thank you very much! No, for such small changes we usually don't bother with changelog entries. |
Collaborator
|
@birkenfeld I've added those to the change log in the past, mostly because it's easier for me to make sure every PR has been processed when writing the changelog, instead of selectively skipping over PRs. |
Member
|
Ok, fair enough 👍 But in any case, the entry is written after the fact, not part of the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be useful if
.pyicode blocks could be syntax highlighted as Python code blocks. Currently, the.pyifile extension is included in file names, and this PR updates it to be used in the sort names too.This cropped up when trying to add syntax highlighting in this issue: astral-sh/ruff#13116.