Added cartouche handling for Isabelle lexer #2159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(lexer.theorem.isabelle): use whitespace token;
Contributor
|
Could you add a test? Either modify the existing |
Contributor
|
Ping @Dacit, do you need help? |
Contributor
Author
Thanks for the offer, I was just very busy and couldn't get to that until now. I'll add tests for that, and even a bit more functionality. |
added 2 commits
June 28, 2022 12:11
feat(lexer.theorem.isabelle): support ascii and unicode sources equally well;
… unicode sources;
Contributor
Author
|
@jean-abou-samra added the tests, now separately for the ascii sources and their unicode rendering (the latter is often used in code snippets, whereas the former is how Isabelle sources are stored). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Isabelle, cartouches are nowadays widely used. However, they can not be parsed by the Isabelle lexer so lots of unparsed tokens are left over - this PR adds better support for them, as well as symbol names in their unicode representation.
Also fixes #1905 for Isabelle.