Add lexer for graphviz#1657
Merged
Anteru merged 1 commit intopygments:masterfrom Feb 7, 2021
nikeee:master
Merged
Conversation
Collaborator
|
Thanks for the contribution! Can you please add an example file as well? |
Contributor
Author
|
I'll take som inspiration from this PR: https://github.com/pygments/pygments/pull/1519/files (on what this PR should also change). |
|
There's some examples here that you could copy: https://github.com/xflr6/graphviz/tree/master/examples/ |
Contributor
Author
|
I updated the PR. |
Anteru
requested changes
Jan 17, 2021
Collaborator
Anteru
left a comment
There was a problem hiding this comment.
Thanks for the contribution, only very minor changes needed before we can land this.
Imported from: https://github.com/nikeee/pygments-lexer-graphviz See: #731
Contributor
Author
|
I pushed an update that addresses the stuff that came up in the review. |
Anteru
approved these changes
Feb 7, 2021
Collaborator
|
Merged for the next release, thanks for your contribution! |
This was referenced Mar 8, 2021
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion here: #731
Resolves #731