Fix mysql analyze text logic#1593
Closed
gandarez wants to merge 0 commit intopygments:masterfrom
gandarez:master
Closed
Fix mysql analyze text logic#1593gandarez wants to merge 0 commit intopygments:masterfrom gandarez:master
gandarez wants to merge 0 commit intopygments:masterfrom
gandarez:master
Conversation
Collaborator
|
I think the point here was to differentiate MySQL from MSSQL, which does use square brackets, and both will probably be trigger happy on SQL text. Was it incorrectly identifying code or what triggered this change? |
Contributor
Author
|
The reason I opnened this PR is because we've been porting pygments lexers to chroma project (GoLang) and the MySQL lexer contains validations (the square brackets) for MSSQL as you already mentioned. What I'm not sure is which weight should I return. |
Contributor
Author
|
@Anteru any update here? |
Contributor
Author
|
Any update here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the documentation MySQL syntax does not allow the usage of square brackets in its queries. Saying it's a truth I removed all the logic comparison between square brackets and backticks.
https://stackoverflow.com/a/9719904/833531
https://dev.mysql.com/doc/refman/8.0/en/identifiers.html