bugfix: fixing rotation behaviour of Sector#1405
Merged
benmoran56 merged 2 commits intopyglet:masterfrom Jan 27, 2026
Merged
Conversation
benmoran56
approved these changes
Jan 27, 2026
Member
|
Thank you for the PR. This looks good. |
Contributor
Author
|
Thank you! Cheers, Thomas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rotation of Sector is used when creating vertices in _get_vertices method. This has the effect of doubling the drawn rotation when e.g. setting radius, angle, etc.
contains method mixes deg and rad when comparing angles, and does not account for negative start_angle and/or negative angle.