Improve documentation of example camera class' end method#1326
Merged
benmoran56 merged 1 commit intopyglet:masterfrom Jun 2, 2025
Merged
Improve documentation of example camera class' end method#1326benmoran56 merged 1 commit intopyglet:masterfrom
benmoran56 merged 1 commit intopyglet:masterfrom
Conversation
benmoran56
approved these changes
Jun 2, 2025
Member
|
Thank you Brett, documentation changes are always appreciated! This reads well to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We successfully used the camera example as a springboard, so thank you for providing it.
While reading through the end method in the example, I thought it read oddly although the gist of the existing code comments are correct. Took a turn a trying to improve the language.
I understand if you don't want to make the change. Thank you for making pyglet available.
~Brett