Skip to content

Add shape guide crossrefs#1291

Merged
benmoran56 merged 7 commits intopyglet:masterfrom
pushfoo:add-shape-guide-crossrefs
Mar 13, 2025
Merged

Add shape guide crossrefs#1291
benmoran56 merged 7 commits intopyglet:masterfrom
pushfoo:add-shape-guide-crossrefs

Conversation

@pushfoo
Copy link
Copy Markdown
Contributor

@pushfoo pushfoo commented Mar 13, 2025

Closes #1289.

benmoran56
benmoran56 previously approved these changes Mar 13, 2025
@benmoran56
Copy link
Copy Markdown
Member

Looks good to me! Let me know when you have finished, and we can merge.

@pushfoo
Copy link
Copy Markdown
Contributor Author

pushfoo commented Mar 13, 2025

@benmoran56 TL;DR: Let's merge as-is.

I have more changes locally, but:

  1. There are a lot of them
  2. I'm not sure whether they're all in-scope for the page
  3. I don't know where to put them
  4. The PR will grow to 400+ lines even if I find a place right away

@benmoran56 benmoran56 merged commit 93ec270 into pyglet:master Mar 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doc: Cross-reference ShapeBase sub-classes from the Programming Guide

2 participants