Fix ImageMouseCursor position not adapting to scaling.#1278
Merged
benmoran56 merged 2 commits intopyglet:masterfrom Feb 16, 2025
Merged
Fix ImageMouseCursor position not adapting to scaling.#1278benmoran56 merged 2 commits intopyglet:masterfrom
benmoran56 merged 2 commits intopyglet:masterfrom
Conversation
- Rename _scaling to scaling - in _on_internal_scale use -8192 to 8192 instead of -255 to 255
benmoran56
approved these changes
Feb 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageMouseCursor was not adapting to scaling which meant that the image position was incorrect.. This fixes that issue, by adding a _scaling property to the ImageMouseCursor, which is set by _on_internal_resize and set_mouse_cursor, but defaults to 1.0. The position of the image is then divided by the _scaling value, which makes the image be in the correct place.