Skip to content

Move testing of GEOS 3.5 to Python 3.6#212

Closed
brendan-ward wants to merge 1 commit intopygeos:masterfrom
brendan-ward:test_geos35
Closed

Move testing of GEOS 3.5 to Python 3.6#212
brendan-ward wants to merge 1 commit intopygeos:masterfrom
brendan-ward:test_geos35

Conversation

@brendan-ward
Copy link
Copy Markdown
Contributor

Adds back in testing of GEOS 3.5 until April 2021.

Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@brendan-ward
Copy link
Copy Markdown
Contributor Author

Unfortunately GEOS 3.5 is not available with Python 3.6 in conda, so this is not quite as easy as I hoped. Don't merge yet...

@brendan-ward
Copy link
Copy Markdown
Contributor Author

Unfortunately it looks like only GEOS >= 3.6 is available for Python 3.6:

> conda search geos
Loading channels: done
# Name                       Version           Build  Channel
geos                           3.6.0      h29919da_2  pkgs/main
geos                           3.6.0      he6050e9_1  pkgs/main
geos                           3.6.2      h5470d99_2  pkgs/main
geos                           3.7.1      h0a44026_0  pkgs/main
geos                           3.8.0      h0a44026_0  pkgs/main
geos                           3.8.0      hb1e8313_0  pkgs/main
geos                           3.8.1      h0a44026_0  pkgs/main
geos                           3.8.1      hb1e8313_0  pkgs/main

> conda search --channel conda-forge geos
Loading channels: done
# Name                       Version           Build  Channel
geos                           3.6.0      h29919da_2  pkgs/main
geos                           3.6.0      he6050e9_1  pkgs/main
geos                           3.6.2   h0a44026_1004  conda-forge
geos                           3.6.2      h5470d99_2  pkgs/main
geos                           3.7.0   h0a44026_1000  conda-forge
geos                           3.7.1      h0a44026_0  pkgs/main
geos                           3.7.1   h0a44026_1000  conda-forge
geos                           3.7.2      h6de7cb9_1  conda-forge
geos                           3.7.2      h6de7cb9_2  conda-forge
geos                           3.7.3      h4a8c4bd_0  conda-forge
geos                           3.8.0      h0a44026_0  pkgs/main
geos                           3.8.0      h4a8c4bd_0  conda-forge
geos                           3.8.0      h4a8c4bd_1  conda-forge
geos                           3.8.0      hb1e8313_0  pkgs/main
geos                           3.8.1      h0a44026_0  pkgs/main
geos                           3.8.1      h4a8c4bd_0  conda-forge
geos                           3.8.1      hb1e8313_0  pkgs/main

It seems like either we have to keep Python 3.5 around a bit longer to be able to test GEOS 3.5 using conda or we install GEOS another way (e.g., via apt-get) for testing this version.

@brendan-ward
Copy link
Copy Markdown
Contributor Author

It looks like Python 3.5 is the default version on Ubuntu 16.04. If we're holding back GEOS version based on 16.04, then it seems like we have to hold back Python to 3.5 as well?

@caspervdw
Copy link
Copy Markdown
Member

In that case I think we should build / cache GEOS ourselves (using https://github.com/Toblerity/Shapely/blob/master/ci/travis/install_geos.sh )

@mwtoews
Copy link
Copy Markdown
Contributor

mwtoews commented Oct 30, 2020

In that case I think we should build / cache GEOS ourselves (using https://github.com/Toblerity/Shapely/blob/master/ci/travis/install_geos.sh )

I can investigate this for Travis CI.

@jorisvandenbossche
Copy link
Copy Markdown
Member

This is now covered by #219

@brendan-ward brendan-ward deleted the test_geos35 branch January 24, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants