Skip to content

Adds support for benchmarking bidirectional sampling#7415

Merged
rusty1s merged 3 commits into
pyg-team:masterfrom
andreazanetti:bidirectional_sampling
May 24, 2023
Merged

Adds support for benchmarking bidirectional sampling#7415
rusty1s merged 3 commits into
pyg-team:masterfrom
andreazanetti:bidirectional_sampling

Conversation

@andreazanetti

Copy link
Copy Markdown
Contributor

Simple addition to enable bidirectional neighbor loader benchmarking.
Results show a relative drop in performance moving from directional to bidirectional (example below) maybe due to the fact that, currently, bidirectional sampling is implemented as a post-processing of regular sampling #7200

With directional sampling:
Dataset: products
Training sampling with [10, 5] neighbors
100%|█████████████████████████████████193/193 [00:03<00:00, 48.96it/s]
100%|█████████████████████████████████ 193/193 [00:03<00:00, 49.59it/s]
100%|█████████████████████████████████ 193/193 [00:03<00:00, 49.01it/s]
batch size=1024, iterations=579, runtimes=[3.943, 3.892, 3.939], average runtime=3.925

while with bidirectional sampling:
Dataset: products
Training sampling with [10, 5] neighbors
100%|██████████████████████████████████ 193/193 [00:04<00:00, 42.22it/s]
100%|██████████████████████████████████193/193 [00:04<00:00, 43.18it/s]
100%|██████████████████████████████████193/193 [00:04<00:00, 42.56it/s]
batch size=1024, iterations=579, runtimes=[4.572, 4.47, 4.535], average runtime=4.526

@rusty1s rusty1s marked this pull request as ready for review May 24, 2023 09:39
@rusty1s rusty1s requested a review from a team as a code owner May 24, 2023 09:39
@rusty1s rusty1s enabled auto-merge (squash) May 24, 2023 09:40
@rusty1s rusty1s merged commit 937f32f into pyg-team:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants