Mark legacy modifier keys and codes as deprecated#49
Merged
pyfisch merged 1 commit intorust-windowing:mainfrom Mar 23, 2025
Merged
Mark legacy modifier keys and codes as deprecated#49pyfisch merged 1 commit intorust-windowing:mainfrom
pyfisch merged 1 commit intorust-windowing:mainfrom
Conversation
Contributor
|
Please rebase the PR. |
Member
Author
|
Rebased now. |
Member
Author
|
Weird, |
4 tasks
Member
Author
Looking at Chromium's source code, it's clear that they do emit these key codes. So I've un-marked them as deprecated for now, and made this PR only focus on the deprecated modifier keys (since that will be confusing when upgrading Winit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves my concern with
Metavs.Superfrom #19.