Skip to content

Conversation

@binbjz
Copy link
Contributor

@binbjz binbjz commented Jan 8, 2026

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
  • Please consider contributing the patch upstream to rbenv,
    since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv
      will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with
      rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR
    • Split the macOS Intel build into a dedicated job.
    • Build the Intel matrix from versions that actually include MacOSX-x86_64 in their definition
      files.
    • Keep non-Intel macOS builds unchanged.

Tests

  • My PR adds the following unit tests (if any)
    • None (workflow-only change; relies on CI jobs)

@binbjz binbjz requested review from a team as code owners January 8, 2026 01:56
@native-api native-api force-pushed the ci/split-intel-macos-build branch from cda2fd0 to 1f77251 Compare January 8, 2026 05:51
@native-api native-api force-pushed the ci/split-intel-macos-build branch from 45f51ec to 640d67f Compare January 8, 2026 05:59
Copy link
Member

@native-api native-api left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Changed the logic to prescribing rather than detecting if MacOS-x64 is supported -- because we do want to verify that all architectures that we expect are present.

@native-api native-api merged commit c35f26a into pyenv:master Jan 8, 2026
20 checks passed
@native-api native-api changed the title split macOS Intel build and filter unsupported Miniconda CI: exclude unsupported MacOS-x64 for recent Miniconda versions Jan 8, 2026
@binbjz binbjz deleted the ci/split-intel-macos-build branch January 8, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants