Fix an infinite loop if a shim is symlinked to and called from a different location with "system" version active #3375
+251
−179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Prerequisite
Description
pyenv-whichused to only delete$PYENV_ROOT/shimsfromPATHwhen looking for an executable for thesystemversion.This PR makes a shim indicate to
pyenv-execthat it's been called from an unusual location, ultimately causingpyenv-whichto delete it fromPATHas well.Moreover,
pyenv-execcompiles a list envvar for "fake" executables for a given command, which prevents a loop even if there's more than one shim onPATH.Tests
Tests for the new functionality