pyenv launcher: introduce and export _PYENV_INSTALL_PREFIX #3334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not interested in this one ? |
Member
|
I was just occupied by other things. In fact, I looked at this a few hours ago. |
native-api
reviewed
Oct 8, 2025
native-api
reviewed
Oct 8, 2025
Contributor
Author
|
Thanks for the feedbacks, will try to make the change in a few days |
Member
|
I apologize for taking long to review. I looked at this soon after you made it, had doubts about it and thought that perhaps I can allocate time to make some own changes to address them myself. But about some of my changes, I wasn't sure, either, so it ultimately went nowhere. Should've probably started a discussion right away -- now all that my strategy achieved is waste 3 weeks. |
edb83c6 to
70747e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add PYENV_INSTALL_PATH as an exposed variable by
pyenvcorresponding to the directory where pyenv is installedTests
Test updated to reflect the change