Skip to content

Conversation

@native-api
Copy link
Member

@native-api native-api commented Jan 22, 2023

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

A missed bit when implementing autoresolution. The code was using -d versions/${version} instead of delegating to pyenv-prefix.
Also did a cleanup to avoid iterating twice.

Tests

  • My PR adds the following unit tests (if any)
  • test for resolving a prefix
  • test for resolving version name for hooks (conda.bash hook in Pyenv-virtualenv uses this)

@native-api native-api merged commit c20fc7b into pyenv:master Jan 22, 2023
@native-api native-api deleted the pyenv_which_latest branch January 22, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyenv-virtualenv not auto-resolve version

1 participant