Skip to content

Conversation

@scop
Copy link
Contributor

@scop scop commented Mar 1, 2021

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

Corresponding rbenv PR: rbenv/rbenv#1311

Tests

  • My PR adds the following unit tests (if any)

N/A

@anton-petrov
Copy link
Member

The Travis CI build failed. @scop Please, check what's wrong, or PR will be deleted. Thanks.

@scop scop force-pushed the shell-detect-improvements branch from 870a781 to 5dd0f0c Compare March 12, 2021 06:34
@scop
Copy link
Contributor Author

scop commented Mar 12, 2021

I'll get to it soon, appreciated if you could keep it open meanwhile.

For example bash-5.1, bash-static.
@scop scop force-pushed the shell-detect-improvements branch from 5dd0f0c to 61d7024 Compare March 23, 2021 21:34
@scop
Copy link
Contributor Author

scop commented Mar 23, 2021

Removed the misguided changes that were causing failures, should be good and trivial to go now.

@anton-petrov anton-petrov merged commit 132d546 into pyenv:master Mar 26, 2021
@scop scop deleted the shell-detect-improvements branch March 27, 2021 08:13
@anton-petrov anton-petrov mentioned this pull request Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants