Conversation
93adae7 to
a72decf
Compare
|
a72decf was because taplo defaults to See formatter options for more. Keeping with the default due to the smaller diff |
|
I'm up for merging ... unless we decide to go with prettier, which covers all of these. I've had a good experience with prettier, because it's a single file manages the formatting for all these formats where we only have a few files. A long track record over at PRQL. But no particularly strong preference... |
|
We already have prettier in precommit, and prettier doesn't support TOML (https://prettier.io/docs/en/). Unless you mean via a prettier plugin like https://www.npmjs.com/package/prettier-plugin-toml, but that is just a wrapper for taplo |
|
👍 for |
|
Ah, thanks, definitely +1 to this, then |
Done (using a suggested config in their readme) |
| "default:Using a non-tuple sequence for multidimensional indexing is deprecated:FutureWarning", | ||
| "default:Duplicate dimension names present:UserWarning:xarray.namedarray.core", | ||
| "default:::xarray.tests.test_strategies", # TODO: remove once we know how to deal with a changed signature in protocols | ||
|
|
There was a problem hiding this comment.
Didn't know that empty lines are allowed, nice.
|
Thanks @VeckoTheGecko ! |
Changes:
validate-pyprojecthookHeyo! Looks like Taplo (https://github.com/tamasfe/taplo) would be a good option (same project as VScode extension Even Better TOML with 2.3M downloads) . They don't have an official hook (tamasfe/taplo#535) but there's an unofficial one at https://github.com/ComPWA/taplo-pre-commit. I don't think they'll get an official one soon as they would need to set up a mirror repo (and best to transfer both repos to an org for that).