use a composite strategy to generate the dataframe with a tz-aware datetime column#9174
Merged
dcherian merged 4 commits intopydata:mainfrom Jul 1, 2024
Merged
Conversation
Contributor
I think our Pandas extra just hasn't been updated to support this yet; mind opening an issue for us? |
Collaborator
Author
|
@dcherian, should we merge this? I can't find a way avoid the composite strategy, so this might be the best we can do right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to use a composite strategy to generate a dataframe with a single timezone-aware datetime column. This works, but it feels somewhat weird to have to jump through hoops just get a standard timezone-aware datetime column.
@Zac-HD, do you have any advice here (as usual, time permitting)? Am I missing anything, or is this something that currently is not supported by
hypothesis.extra.pandas? For context, what we have right now onmainreturns object dtypes, not the timezone-aware extension dtypes.