Update resample time offset FutureWarning and docs#8479
Merged
dcherian merged 8 commits intopydata:mainfrom Nov 29, 2023
Merged
Update resample time offset FutureWarning and docs#8479dcherian merged 8 commits intopydata:mainfrom
dcherian merged 8 commits intopydata:mainfrom
Conversation
As discussed in pydata#8175
Illustrate updating the time coordinate values of a resampled dataset using time offset arithmetic. This is the recommended technique to replace the use of the deprecated `loffset` parameter in `resample()` re: issue pydata#7596 and discussion pydata#8175
max-sixty
reviewed
Nov 23, 2023
max-sixty
approved these changes
Nov 23, 2023
Collaborator
max-sixty
left a comment
There was a problem hiding this comment.
Looks good! Thanks @douglatornell
Contributor
Author
|
Thanks for the lightning fast review @max-sixty ! |
Contributor
Author
max-sixty
reviewed
Nov 23, 2023
max-sixty
reviewed
Nov 23, 2023
Collaborator
|
I'll wait for @dcherian to have a look before hitting the big button |
max-sixty
reviewed
Nov 24, 2023
dcherian
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the text of the
FutureWarningre: deprecation of theloffsetparameter in theDataWithCoords._resample().Add deprecation notices about
loffsetto theDataset.resample()and DataArray.resample()` docstrings.Add illustration of updating the time coordinate values of a resampled dataset using time offset arithmetic to the Time series data - Resampling and grouped operations section of the user guide.
whats-new.rst