Bump minimum numpy version to 1.20#6834
Conversation
|
Hmm... doesn't seem like we can do this yet: |
|
Ok seems @Illviljan and myself were a few month off xD #6821 (comment). Nvmd then :) |
|
Oh no, I read the wrong table, sorry about that. :( It's this table https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule : |
|
Looks like we can bump a bunch of others if you're up for it :) |
We are dropping 1.19 here, where this table says: |
|
you can probably use the I think we can drop |
|
Ok I think I found my misunderstanding. Instead of dropping versions older than 18 month we want the oldest supported version to be at least 18 month old. |
|
Anyone know why min all deps fails? |
|
I got rid of the complete npcompat module. |
|
@dcherian I see that you were working on this the last time. We should really merge this, since all CI runs are currently broken due to new flox requiring numpy>=1.20 |
I haven't ran into this issue since I've only committed documentation and README updates for the repo. @jasonb5 maintains the repo dependencies, so let's see if he can help. Jason, can you try taking a look at this issue? It looks like As a side-note, |
|
Is there a reason why the minimum versions are not in the additional requirements in setup.cfg? |
See #5578 |
for more information, see https://pre-commit.ci
|
@dcherian @tomvothecoder |
|
We usually only fix the minor version, in this case LGTM! |
whats-new.rstNew functions/methods are listed inapi.rstAlternative to #6821