Add a days_in_month accessor to CFTimeIndex#3935
Merged
dcherian merged 7 commits intopydata:masterfrom Apr 6, 2020
Merged
Conversation
dcherian
approved these changes
Apr 5, 2020
Contributor
dcherian
left a comment
There was a problem hiding this comment.
Thanks @spencerkclark . LGTM.
Can you strip outputs from the notebook? That should reduce the diff here and later when it gets updated next.
Member
Author
That didn't occur to me, thanks. That's indeed much better. I added a documentation note as well; things should hopefully be all set now. |
Member
|
Fantastic! Thanks @spencerkclark! |
jhamman
reviewed
Apr 5, 2020
Contributor
|
Thanks @spencerkclark |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isort -rc . && black . && mypy . && flake8whats-new.rstfor all changes andapi.rstfor new APIThis adds a
days_in_monthaccessor to CFTimeIndex, which allows for easy computation of monthly time weights for non-standard calendars:This simplifies the "Calculating Seasonal Averages from Timeseries of Monthly Means" example @jhamman wrote for the docs a while back, which I've taken the liberty of updating.
The ability to add this feature to xarray is thanks in large part to @huard, who added a
daysinmonthattribute tocftime.datetimeobjects late last year: Unidata/cftime#138.