Skip to content

Add persist method to DataSet#1349

Merged
shoyer merged 6 commits intopydata:masterfrom
mrocklin:persist
Apr 4, 2017
Merged

Add persist method to DataSet#1349
shoyer merged 6 commits intopydata:masterfrom
mrocklin:persist

Conversation

@mrocklin
Copy link
Contributor

@mrocklin mrocklin commented Apr 3, 2017

Fixes #1344

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master | flake8 --diff
  • whatsnew entry (not sure what to do here, is there a new section? It looks like the last release was yesterday)

@mrocklin
Copy link
Contributor Author

mrocklin commented Apr 3, 2017

I suspect that there is more to do here, but I wanted to get the ball rolling on this.

cc @shoyer @rabernat @pwolfram

@rabernat
Copy link
Contributor

rabernat commented Apr 4, 2017

Would it make sense to have persist for DataArrays as well? My opinion is: yes.

@shoyer
Copy link
Member

shoyer commented Apr 4, 2017

Thanks @mrocklin! This is a great start.

Yes, it would be great to have this on DataArray as well. The implementation would be a two liner:

    def persist(self):
        ds = self._to_temp_dataset().persist()
        return self._from_temp_dataset(ds)

I just pushed a commit to master adding a "what's new" template for v0.9.3.

@mrocklin
Copy link
Contributor Author

mrocklin commented Apr 4, 2017

Added DataArray.persist and a whats new entry

@rabernat
Copy link
Contributor

rabernat commented Apr 4, 2017

Would also probably be good to document this a bit in the section on dask:
https://github.com/pydata/xarray/blob/master/doc/dask.rst

@mrocklin
Copy link
Contributor Author

mrocklin commented Apr 4, 2017

Added docs. Also removed section on dask.array not providing automatic chunk alignment (this is now supported)

@rabernat
Copy link
Contributor

rabernat commented Apr 4, 2017

This looks good to go from my point of view!

@shoyer shoyer merged commit 9479038 into pydata:master Apr 4, 2017
@shoyer
Copy link
Member

shoyer commented Apr 4, 2017

Thanks @mrocklin!

I'm glad to see your first commit on the xarray side :).

@mrocklin
Copy link
Contributor Author

mrocklin commented Apr 4, 2017 via email

@rabernat
Copy link
Contributor

rabernat commented Apr 4, 2017

I'm glad to see your first commit on the xarray side :).

Hopefully the first of many!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dask Persist

3 participants