Deploying with    Cloudflare Pages

View logs

Awesome thank you, definitely a step in the right direction!

❯ pip install -Uq pydantic
❯ python -m timeit -n 1 -r 1 "import pydantic"
1 loop, best of 1: 83.4 msec per loop
❯ python -m timeit -n 1 -r 1 "from pydantic import BaseModel"
1 loop, best of 1: 89.6 msec per loop
❯ pip install -Iq "pydantic @ git+https://github.com/pydantic/pydantic.git@defer-init-imports"
❯ python -m timeit -n 1 -r 1 "import pydantic"
1 loop, best of 1: 15.7 msec per loop
❯ python -m timeit -n 1 -r 1 "from pydantic import BaseModel"
1 loop, best of 1: 79 msec per loop

Do you see a way to reduce the import cost of BaseModel any further? That is what I, and I think most others, are optimizing for because that is the main interface that classes in one's code will inherit at import time.

That last commit helped a little!

❯ python -m timeit -n 1 -r 1 "from pydantic import BaseModel"
1 loop, best of 1: 63.9 msec per loop

@ofek that's great, I was able to avoid importing pydantic.fields in that which should have helped a fair bit.

Could you show me the output of importtime using tuna from your system, that might help me know where to look.

@ofek I've got rid of import time import of annotated-types, with that I see a >38% improvement. I really don't think there's much more I can do from there.

If you see anything else, let me know.

I think this is ready.

Please review @sydney-runkle

Thank you!

❯ python -m timeit -n 1 -r 1 "from pydantic import BaseModel"
1 loop, best of 1: 56.8 msec per loop

I don't think anything in logs, I think it merits a prominent notice in the release notes and a tweet from me now saying we're doing it.

AFAIK this shouldn't affect anyone and I made the change in few steps to see, but the only real answer is to release it and see.

Out of curiosity, how will the practice of being conscious about import time be maintained during continued development?

I've added unit tests that that those modules aren't imported in specific cases, e.g. from pydantic import BaseModel.

The longer term solution is all down to @art049 - we should use Codspeed for continuous profile of stuff we care about like import time, as we do on pydantic-core.