Skip to content

Add support for NotRequired generics in TypedDict#7932

Merged
sydney-runkle merged 2 commits intomainfrom
fix-tuple-handling-for-generic-types
Oct 26, 2023
Merged

Add support for NotRequired generics in TypedDict#7932
sydney-runkle merged 2 commits intomainfrom
fix-tuple-handling-for-generic-types

Conversation

@sydney-runkle
Copy link
Copy Markdown
Contributor

@sydney-runkle sydney-runkle commented Oct 26, 2023

Change Summary

Add support for NotRequired generics in TypedDict

Related issue number

Fix #7931

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Oct 26, 2023
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Oct 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 257ddd6
Status: ✅  Deploy successful!
Preview URL: https://2b106fcc.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-tuple-handling-for-gener.pydantic-docs2.pages.dev

View logs

@sydney-runkle
Copy link
Copy Markdown
Contributor Author

Please review

Comment thread tests/test_generics.py Outdated
Comment thread pydantic/_internal/_generics.py
@sydney-runkle sydney-runkle enabled auto-merge (squash) October 26, 2023 14:05
@sydney-runkle sydney-runkle merged commit 064b24c into main Oct 26, 2023
@sydney-runkle sydney-runkle deleted the fix-tuple-handling-for-generic-types branch October 26, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NotRequired receives (T,) instead of T in Generic TypedDict

3 participants