Save return type generated from type annotation in ComputedFieldInfo#7889
Merged
sydney-runkle merged 1 commit intopydantic:mainfrom Oct 25, 2023
Merged
Conversation
Contributor
Author
|
please review |
sydney-runkle
approved these changes
Oct 25, 2023
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Contributor
|
Great! Thanks all for super fast turn around :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
GenerateSchema._computed_field_schemaalready looks at the return type annotation to determine the final return type of a computed field, this just saves that in theComputedFieldInfo.return_type.Related issue number
Closes #7858
Checklist
Selected Reviewer: @Kludex