Add more specific type for non-callable json_schema_extra#7803
Merged
sydney-runkle merged 11 commits intopydantic:mainfrom Oct 12, 2023
Merged
Add more specific type for non-callable json_schema_extra#7803sydney-runkle merged 11 commits intopydantic:mainfrom
json_schema_extra#7803sydney-runkle merged 11 commits intopydantic:mainfrom
Conversation
…add JsonDict for convenience
Contributor
Author
|
please review |
dmontagu
approved these changes
Oct 12, 2023
Contributor
|
@alexmojaki looks great, thanks for the contribution ⭐ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds these types:
and replaces
dict[str, object]withJsonDicton annotations ofjson_schema_extra.Related issue number
Closes #6348
Replaces #7475 which seems to have died and implements the suggestions.
Checklist
Selected Reviewer: @lig