Support specification of strict on Enum type fields#7761
Merged
sydney-runkle merged 1 commit intomainfrom Oct 8, 2023
Merged
Conversation
Contributor
Author
|
Please review |
davidhewitt
approved these changes
Oct 6, 2023
Collaborator
davidhewitt
left a comment
There was a problem hiding this comment.
Fix looks good to me.
I half wonder whether there's a way that we could inspect the core_schema methods to figure out what the allowed constraints could be (but probably that's a complex algorithm which isn't great to run on startup time).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Support specification of
strictonEnumtype fieldsMore broadly, this allows for the
strictspecification to be added tolax-or-strictschema, where it's expected but for some reason wasn't allowed to be added.Fix #7759
Checklist
Selected Reviewer: @lig