Fix an issue where JSON schema extras weren't JSON encoded#7625
Merged
Fix an issue where JSON schema extras weren't JSON encoded#7625
Conversation
Deploying with
|
| Latest commit: |
b6c62e3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7508f175.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dmontagu-fix-unencoded-json.pydantic-docs2.pages.dev |
Contributor
Author
|
Note this doesn't affect the result of a mutating |
Kludex
approved these changes
Sep 26, 2023
2 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes fastapi/fastapi#10321
As far as I can tell, in v1, we would json encode anything extra (which included the examples). So I think this is restoring intended behavior (and as far as I can imagine is objectively better behavior in all circumstances where it might affect things).
@Kludex for reference