Conversation
Deploying with
|
| Latest commit: |
b4df1f2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://411e013e.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dmontagu-base64url-types.pydantic-docs2.pages.dev |
Kludex
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lack of these led to some confusion when talking with @Kludex about
ser_json_bytes. Seemed easy enough to just add them.@samuelcolvin and I discussed at some point possibly adding support for serializing json bytes as vanilla (non-URL-safe) base64 in pydantic core, but I think that's unnecessary for now (pydantic core will always serialize as url-safe base64 when that config setting is equal to
'base64').