Fix hash function generation for frozen models with unusual MRO#7274
Merged
Fix hash function generation for frozen models with unusual MRO#7274
Conversation
Deploying with
|
| Latest commit: |
3f0374e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ac06795b.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dmontagu-generic-hashing.pydantic-docs2.pages.dev |
dmontagu
commented
Aug 29, 2023
| class C(B): | ||
| pass | ||
|
|
||
| assert get_attribute_from_bases(C, 'x') == 2 |
Contributor
Author
There was a problem hiding this comment.
Currently on the main branch, this returns 1 @adriangb
Member
There was a problem hiding this comment.
Oh wow I’m very glad you caught this 🙈
Contributor
Author
|
please review |
adriangb
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7236
Also fixes a bug with the way attributes were read from nested typeddicts (mro was being iterated over in reverse order), and adds a related test.
Selected Reviewer: @hramezani