Skip to content

Move function is_pydantic_dataclass from pydantic._internal._dataclasses to pydantic.dataclasses#7213

Merged
adriangb merged 4 commits intopydantic:mainfrom
GabrielCappelli:make_is_pydantic_dataclass_public
Aug 24, 2023
Merged

Move function is_pydantic_dataclass from pydantic._internal._dataclasses to pydantic.dataclasses#7213
adriangb merged 4 commits intopydantic:mainfrom
GabrielCappelli:make_is_pydantic_dataclass_public

Conversation

@GabrielCappelli
Copy link
Copy Markdown
Contributor

@GabrielCappelli GabrielCappelli commented Aug 22, 2023 •
edited by pydantic-hooky Bot
Loading

Change Summary

Moves is_pydantic_dataclass function from _internals to public api in pydantic.dataclasses.
Adds unit test for is_pydantic_dataclass.

Related issue number

fix #7207

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@GabrielCappelli
Make func is_pydantic_dataclass public
2fe4aff 
Move is_pydantic_dataclass to pydantic.dataclasses
Add test for is_pydantic_dataclass
Add documentation for is_pydantic_dataclass
@GabrielCappelli GabrielCappelli force-pushed the make_is_pydantic_dataclass_public branch from 2255d4e to 2fe4aff Compare August 22, 2023 16:51
@GabrielCappelli
Copy link
Copy Markdown
Contributor Author

GabrielCappelli commented Aug 22, 2023

please review

adriangb
adriangb requested changes Aug 22, 2023
View reviewed changes
Comment thread pydantic/_internal/_generate_schema.py Outdated
Comment thread pydantic/dataclasses.py Outdated
@pydantic-hooky pydantic-hooky Bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Aug 22, 2023
@pydantic-hooky pydantic-hooky Bot assigned GabrielCappelli and unassigned adriangb Aug 22, 2023
@GabrielCappelli @adriangb
Use relative import when importing is_pydantic_dataclass in _generate…
b86eb77 
…_schema

Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
@GabrielCappelli
Copy link
Copy Markdown
Contributor Author

GabrielCappelli commented Aug 24, 2023

please review

@pydantic-hooky pydantic-hooky Bot added ready for review and removed awaiting author revision awaiting changes from the PR author labels Aug 24, 2023
@pydantic-hooky pydantic-hooky Bot assigned adriangb and unassigned GabrielCappelli Aug 24, 2023
adriangb
adriangb reviewed Aug 24, 2023
View reviewed changes
Comment thread pydantic/dataclasses.py Outdated
@adriangb
Copy link
Copy Markdown
Member

adriangb commented Aug 24, 2023

please fix conflicts, otherwise LGTM!

@adriangb adriangb enabled auto-merge (squash) August 24, 2023 14:34
@adriangb adriangb merged commit 26f0eab into pydantic:main Aug 24, 2023
@GabrielCappelli
Copy link
Copy Markdown
Contributor Author

GabrielCappelli commented Aug 24, 2023

please fix conflicts, otherwise LGTM!

Thank you very much! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adriangb adriangb adriangb approved these changes

Assignees

@adriangb adriangb

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add is_pydantic_dataclass to public API

2 participants

@GabrielCappelli @adriangb