Do not require validate_assignment to use Field.frozen#7103
Merged
samuelcolvin merged 8 commits intopydantic:mainfrom Aug 15, 2023
Merged
Do not require validate_assignment to use Field.frozen#7103samuelcolvin merged 8 commits intopydantic:mainfrom
validate_assignment to use Field.frozen#7103samuelcolvin merged 8 commits intopydantic:mainfrom
Conversation
Member
|
It is intended behavior. The second example will work if Probably we can improve the the docstring and documentation here |
Member
Author
|
Then should the first example I gave follows the same idea (requiring |
Member
Author
|
Please review |
hramezani
approved these changes
Aug 15, 2023
samuelcolvin
approved these changes
Aug 15, 2023
Member
samuelcolvin
left a comment
There was a problem hiding this comment.
LGTM, thanks so much for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
I find it a bit unusual to have the following working:
But not the following:
If you think the current behavior is as designed, I can revert my commit but I think a note on the
Field.frozendocstring would be required.Checklist
Selected Reviewer: @samuelcolvin