add field_serializer to computed_field#6965
Merged
adriangb merged 5 commits intopydantic:mainfrom Aug 1, 2023
Merged
Conversation
Contributor
Author
|
Updating unit tests |
Contributor
Author
|
please review |
Member
|
This looks good @andresliszt ! Can you add a test using |
Contributor
Author
done!, is that what you wanted? Thanks for the observation |
0501342 to
d7adcec
Compare
adriangb
approved these changes
Aug 1, 2023
13 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to add
field_seralizerinto computed fields described in #6964Checklist
Selected Reviewer: @hramezani