Skip to content

Fix annotated_types.MaxLen validator for custom sequence types#6809

Merged
samuelcolvin merged 3 commits intopydantic:mainfrom
ImogenBits:fix_MaxLen
Jul 24, 2023
Merged

Fix annotated_types.MaxLen validator for custom sequence types#6809
samuelcolvin merged 3 commits intopydantic:mainfrom
ImogenBits:fix_MaxLen

Conversation

@ImogenBits
Copy link
Copy Markdown
Contributor

@ImogenBits ImogenBits commented Jul 22, 2023 •
edited by pydantic-hooky Bot
Loading

Change Summary

Makes the validator function used for annotated_types.MaxLen with custom sequences use an inclusive upper bound.

Related issue number

fix #6808

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@ImogenBits
Copy link
Copy Markdown
Contributor Author

ImogenBits commented Jul 22, 2023

please review

didn't add any unit tests as I'm not sure where they would go, can't find any similar ones.

hramezani
hramezani reviewed Jul 23, 2023
View reviewed changes
Comment thread pydantic/_internal/_validators.py Outdated
@hramezani
Copy link
Copy Markdown
Member

hramezani commented Jul 23, 2023

Thanks @ImogenBits for this patch 👍

didn't add any unit tests as I'm not sure where they would go, can't find any similar ones.

You can adjust the test in

pydantic/tests/test_types.py

Line 5379 in 5320764

def test_constraints_arbitrary_type() -> None:

please update

@pydantic-hooky pydantic-hooky Bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Jul 23, 2023
@pydantic-hooky pydantic-hooky Bot assigned ImogenBits and unassigned dmontagu Jul 23, 2023
@hramezani
Copy link
Copy Markdown
Member

hramezani commented Jul 24, 2023

please review

@pydantic-hooky pydantic-hooky Bot added ready for review and removed awaiting author revision awaiting changes from the PR author labels Jul 24, 2023
@pydantic-hooky pydantic-hooky Bot assigned dmontagu and unassigned ImogenBits Jul 24, 2023
@hramezani
Copy link
Copy Markdown
Member

hramezani commented Jul 24, 2023

Please review

@samuelcolvin samuelcolvin enabled auto-merge (squash) July 24, 2023 20:00
@samuelcolvin samuelcolvin merged commit 9fe3802 into pydantic:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hramezani hramezani hramezani left review comments

@samuelcolvin samuelcolvin samuelcolvin approved these changes

Assignees

@dmontagu dmontagu

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MaxLen annotation validator for custom sequences is incorrect

4 participants

@ImogenBits @hramezani @samuelcolvin @dmontagu