Skip to content

Fix pydantic dataclasses that use slots with default values#6796

Merged
samuelcolvin merged 2 commits intomainfrom
fix-dataclass-with-slots-defaults
Jul 21, 2023
Merged

Fix pydantic dataclasses that use slots with default values#6796
samuelcolvin merged 2 commits intomainfrom
fix-dataclass-with-slots-defaults

Conversation

@dmontagu
Copy link
Copy Markdown
Contributor

Closes #6783

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jul 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 35bc81e
Status: ✅  Deploy successful!
Preview URL: https://bf00d3f6.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-dataclass-with-slots-def.pydantic-docs2.pages.dev

View logs

Copy link
Copy Markdown
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelcolvin samuelcolvin enabled auto-merge (squash) July 21, 2023 17:36
@samuelcolvin samuelcolvin merged commit 9fb218b into main Jul 21, 2023
@samuelcolvin samuelcolvin deleted the fix-dataclass-with-slots-defaults branch July 21, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating dataclass(slots=True) instance fails with defaults

2 participants