Skip to content

Use OrderedDict from typing_extensions#6664

Merged
dmontagu merged 1 commit intomainfrom
typing-extensions-ordered-dict
Jul 13, 2023
Merged

Use OrderedDict from typing_extensions#6664
dmontagu merged 1 commit intomainfrom
typing-extensions-ordered-dict

Conversation

@dmontagu
Copy link
Copy Markdown
Contributor

@dmontagu dmontagu commented Jul 13, 2023 •
edited by pydantic-hooky Bot
Loading

Closes #6426

Note that this is the relevant code in typing_extensions:

# 3.7.2+
if hasattr(typing, 'OrderedDict'):
    OrderedDict = typing.OrderedDict
# 3.7.0-3.7.2
else:
    OrderedDict = typing._alias(collections.OrderedDict, (KT, VT))

Given that, I think this is safe to merge. @Kludex I understand where you are coming from with not fixing it but given its so simple I think it's worth just doing it.

Selected Reviewer: @adriangb

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jul 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4eba030
Status: ✅  Deploy successful!
Preview URL: https://0256a439.pydantic-docs2.pages.dev
Branch Preview URL: https://typing-extensions-ordered-di.pydantic-docs2.pages.dev

View logs

@dmontagu
Copy link
Copy Markdown
Contributor Author

dmontagu commented Jul 13, 2023

Please review

@dmontagu dmontagu merged commit e27243d into main Jul 13, 2023
@dmontagu dmontagu deleted the typing-extensions-ordered-dict branch July 13, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adriangb adriangb adriangb approved these changes

Assignees

@adriangb adriangb

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

not compatible with python 3.7.1

2 participants

@dmontagu @adriangb