Skip to content

Fix list markdown in transform docstring#6649

Merged
hramezani merged 1 commit intopydantic:mainfrom
StefanBRas:sras/fix-markdown-in-transform-docstring
Jul 13, 2023
Merged

Fix list markdown in transform docstring#6649
hramezani merged 1 commit intopydantic:mainfrom
StefanBRas:sras/fix-markdown-in-transform-docstring

Conversation

@StefanBRas
Copy link
Copy Markdown
Contributor

@StefanBRas StefanBRas commented Jul 13, 2023 •
edited
Loading

Change Summary

Fix list markdown in transform docstring by adding an empty line.
Before:
Screenshot 2023-07-13 150150
After:
Screenshot 2023-07-13 150032

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@StefanBRas
Copy link
Copy Markdown
Contributor Author

StefanBRas commented Jul 13, 2023

please review

@StefanBRas
Copy link
Copy Markdown
Contributor Author

StefanBRas commented Jul 13, 2023

I of course can't be entirely sure, but I'm pretty convinced that the test fail isn't due to my change.

@hramezani
Copy link
Copy Markdown
Member

hramezani commented Jul 13, 2023

Thanks @StefanBRas

@hramezani hramezani merged commit 29751c0 into pydantic:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hramezani hramezani hramezani approved these changes

Assignees

@dmontagu dmontagu

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StefanBRas @hramezani @dmontagu