Skip to content

Make validate_call work on basemodel methods#6569

Merged
Kludex merged 3 commits intomainfrom
validate-call-basemodel-method
Jul 12, 2023
Merged

Make validate_call work on basemodel methods#6569
Kludex merged 3 commits intomainfrom
validate-call-basemodel-method

Conversation

@dmontagu
Copy link
Copy Markdown
Contributor

@dmontagu dmontagu commented Jul 10, 2023

Closes #6567

Selected Reviewer: @hramezani

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jul 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 93655e7
Status: ✅  Deploy successful!
Preview URL: https://b089e47c.pydantic-docs2.pages.dev
Branch Preview URL: https://validate-call-basemodel-meth.pydantic-docs2.pages.dev

View logs

@dmontagu
Copy link
Copy Markdown
Contributor Author

please review

) -> tuple[Any, list[Any]] | None:
from ._std_types_schema import PREPARE_METHODS

# This check for hashability is only necessary for python 3.7
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@Kludex Kludex merged commit c4b40f2 into main Jul 12, 2023
@Kludex Kludex deleted the validate-call-basemodel-method branch July 12, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@validate_call fails on an instance method of a Pydantic Model

3 participants